Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMAPP-163: PGP Key Feature in channels module #164

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

meKushdeepSingh
Copy link
Collaborator

  • Updated dependency: "@pushprotocol/restapi" to "^1.7.30"
  • Modified subscription status component to check if the profile is locked and display the unlock profile modal
  • Updated subscription API parameters to include the PGP private key

- Updated dependency: "@pushprotocol/restapi" to "^1.7.30"
- Modified subscription status component to check if the profile is locked and display the unlock profile modal
- Updated subscription API parameters to include the PGP private key
@meKushdeepSingh meKushdeepSingh self-assigned this Feb 4, 2025
@meKushdeepSingh meKushdeepSingh linked an issue Feb 4, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 4, 2025

In the package.json file, everything looks good.

In the SubscriptionStatus.tsx file:

  • There is a missing closing curly brace (}) for the ChannelPendingSubscriptionType type declaration.
  • In the checkIfGuest function, the return false; statement is placed outside the if block. It should be within the block.
  • There is an extra comma after the showUnlockProfileModal() function call which should be removed.
  • The setTimeout(() => { ... })() pattern is not recommended in JavaScript. It should be refactored for readability.
  • There are unused parameters in the handleChangeSubStatus function.

In the ChannelsDisplayer.tsx file:

  • There is a missing closing curly brace (}) for the ChannelItem component props within the renderItem callback.
  • The ListFooterComponent callback is missing a closing curly brace (}).
  • The closing curly brace after the ListFooterComponent should be moved before the View component.
  • There is a missing closing curly brace for the ChannelsDisplayer component at the end of the file.

For the PushApiContext.tsx, useSubscriptions.tsx, and channelSlice.ts files, the content is not provided, so I cannot review them.

Overall, there are a few mistakes and typos that need to be fixed in the specified files.

Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Just found one bug that we don't see the unlock profile modal after clicking on the subscribe/unsubscribe button for the very first time when we install the app.

- Fix: Display unlock profile modal when user clicks on the subscribe button for the first time after installing the app.
Copy link

github-actions bot commented Feb 4, 2025

In the package.json file:

  1. The script android seems to duplicate the script android:staging. One of them might be unnecessary.
  2. There is a missing closing brace (}) for the ChannelPendingSubscriptionType object in the SubscriptionStatus.tsx file.

In the SubscriptionStatus.tsx file:

  1. The useEffect hook has incomplete comments. It seems like some logic or handling is missing in those sections.
  2. The checkIfGuest function is missing a closing curly brace (}) before return false;.
  3. Within the handleChangeSubStatus function, there seems to be missing logic or comments. It ends abruptly without completing the intended actions.

In the ChannelsDisplayer.tsx file:

  1. There is a missing closing brace (}) for the ChannelItem component in the renderItem function.
  2. The ListFooterComponent function is missing a closing brace (}).
  3. The styles object seems incomplete, and the closing brace for styles is missing.

For the PushApiContext.tsx, useSubscriptions.tsx, and channelSlice.ts, since the contents of the files are not provided, I cannot review them.

Please complete the missing parts and ensure the logic in the files is accurate.

@rohitmalhotra1420 rohitmalhotra1420 merged commit 3ae05a6 into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle PGP Key Feature for Channels module in Mobile App
2 participants